feature: Create LambdaProxyEvent Type #18
Conversation
|
Can one of the admins verify this patch? |
5 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
idelfonsog2
force-pushed
the
feature/lambda-proxy-event-type
branch
from
62da079 to
fa43957
Compare
idelfonsog2
force-pushed
the
feature/lambda-proxy-event-type
branch
from
fa43957 to
4690233
Compare
Co-authored-by: Fabian Fett <fabianfett@apple.com>
Co-authored-by: Fabian Fett <fabianfett@apple.com>
Co-authored-by: Fabian Fett <fabianfett@apple.com>
Co-authored-by: Fabian Fett <fabianfett@apple.com>
Co-authored-by: Fabian Fett <fabianfett@apple.com>
Co-authored-by: Fabian Fett <fabianfett@apple.com>
Co-authored-by: Fabian Fett <fabianfett@apple.com>
Co-authored-by: Fabian Fett <fabianfett@apple.com>
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| public struct LambdaProxyEvent: Codable { |
There was a problem hiding this comment.
Since we are only ever decoding these events, is Decodable conformance enough?
There was a problem hiding this comment.
iiuc this is specifically for an APIGateway proxy? If so, should we use a less generic name than LambdaProxyEvent?
There was a problem hiding this comment.
-
I would agree with keeping the type only to the Decodable
-
The name was suggested by Fabian, how about 'LambdaGatewayProxyEvent' ? Trying to keep the length to a minimum also
|
@swift-server-bot test this please |
|
thanks for the PR @idelfonsog2, looks great! some small questions |
chore: make Type only Decoable chore: run soundness.sh
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
|
lgtm, lets also see what @fabianfett thinks |
Create LambdaProxyEvent
previous PR with original template #16
Motivation:
I was getting Decoding errors when invoking my lambda using APIGateway Event Request. I looked at the AWS Documentation and Serverless documentation and notice a different object from what is currently in the package
Modifications:
Edit a couple of the properties in the APIGatewayV2Request
Result:
My lambda is able to receive the Event from APIGateway along with the body I included in my http request